Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SassC dependency to Dart Sass #790

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ayaman
Copy link
Contributor

@ayaman ayaman commented Oct 3, 2024

Since SassC no longer supports the newer syntax used in foundation 6.8+, this pull request changes the dependency to Dart Sass.

@tlbraams
Copy link

tlbraams commented Oct 4, 2024

I'm not familiar with the dartsass libraries, but it looks like sass-embedded and sassc-embedded are actively maintained and the library chosen by dartsass-rails, while dartsass was last updated 2 years ago.

@ayaman
Copy link
Contributor Author

ayaman commented Oct 4, 2024

You're quite right. I use dartsass-rails so I mistakenly assumed that they use dartsass. It seems sassc-embedded is the recommended option to go for. I'll adjust the pull request.

murb pushed a commit to qkunst/collectiemanagement that referenced this pull request Oct 18, 2024
@arta
Copy link

arta commented Nov 5, 2024

I just went through the transition from sassc to dartsass-rails and it installs sass-embedded (not sassc-embedded) as its dependency, just thought I'd mention this. Also visible here: https://rubygems.org/gems/dartsass-rails/versions/0.5.1

@javierjulio
Copy link

I'm going through the same migration but I've decided to replace the gem with a foundation-sites NPM install since the package is updated and it has no dependencies. I'm not sure if it would be possible for the gem without a major release but ideally it should not have sass, sassc, sass*-embedded or sprockets-es6 as dependencies. The latter is unnecessary and the former would be best to let the host app decide. Note that the foundation-sites does not specify a sass or babel dependency as an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants