Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the unit test
test_version_update_pypi()
was not correctly loading the server configuration. The test was passing simply because the first assertion assumed a configuration was used that happened to match the default configuration. If the configuration off90_config.json
were to be changed in a way that should affect the test, the test would have failed.The unit test is updated to match the paradigm of the other unit tests in this file, deferring the server init to
unittest_server_init()
, which does correctly load the configuration.Furthermore, if the unit tests are run in a conda environment, the test was erroneously failing. In such an environment, the expected outcome should be different than the one assumed by the CI. In order to satisfy both, the unit test now checks the environment and determines the expected value for the assertion accordingly so it passes in all environments.
This supersedes #346 and incorporates some changes that crept into #341. Recommend merging this first, and then the #341 PR can be rectified.