Add fpm support for fftapck with double precision #2
Conversation
Move source code to `src` and `test` folder. Move doc files to `doc` folder. Rewrite Makefiles.
There was a problem hiding this comment.
Next time I will try to add CI to this fftpack library, just like Minpack : CI.
| You can build using provided `fpm.toml`: | ||
| ```bash | ||
| fpm build --flag "-O2" | ||
| fpm test --flag "-O2" tstfft |
There was a problem hiding this comment.
Because the fpm software uses the -fcheck=bounds flag option by default, this is not compatible with the source code of fftpack now.
For example in your repo here:
https://github.com/certik/fftpack/blob/030cbf4fd35c35ef19387b4835bde3ac73019b64/cosqb1.f#L3
They shall be:
DIMENSION X(*) ,W(*) ,XH(*) I will fix all of them next time, see my done repo fortran-fans/fftpack4.0-public-domain:
|
Thanks! Let me test this out to see if it works. |
|
I tested it, and it builds! |
|
I added you to the repository, so you will be able to merge PRs. Go ahead and submit the CI as you mentioned, I'll try to review quickly once you send it. Thank you! |
|
Thanks! @certik |
srcandtestfolder.docfolder.Notes
About brocolis/fftpack, it is from netlib/fftpack4.0 with single precision.
About certik/fftpack, it is from netlib/dfftpack1.0(fftpack4.0) with double precision.
The open source agreement of the above packages is public domain, it is more user-friendly.
About fftpack5.1 discussed in issue #1 , based on the open source license, I do not add fpm support for them now.
nacr/fftpack5.1 uses a unique FFTPack license for open source (see #1).
John/fftpack5.1 uses the LGPL license for open source (see #1).