You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You recommended me (see fortran-lang/fpm-registry#40 (comment)) to check whether the code in this repository(certik/fftpack) is consistent with netlib/dfftpack1.0 (fftpack4.0). I confirm that they are consistent.
And I want to learn from brocolis/fftpack to make dfftpack1.0(fftpack4.0) also support fpm. I will do this immediately.
Later, We update dfftpack1.0(fftpack4.0) to fftpack5.1: netlib/dfftpack1.0(fftpack4.0) with a easy-to-use interface (-> ncar/fftpack5.1 with a easy-to-use interface -> john/fftpack5.1 with a easy-to-use interface) -> fftpack5.1 with a easy-to-use interface.
I got inspiration from stdlib, I think we can use fypp as a preprocessor to deal with the multi-precision problem of fftpack package.
Do we need to use fypp to refactor netlib/dffpack1.0(fftpack4.0) and nacr/fftpack5.1?
Tasks
Let's collect the original sources from netlib. Commit. This might be similar to https://github.com/certik/fftpack, but we should check we got everything.
We should add Fortran 90 interface to the package (add fpm support, keep make support)
Add 2D and 3D transforms
Check any other functionality from the repositories you mentioned and see if there is anything else that we should include
Such as fftshift, czt, hilbert, filter.
I am happy that fpm supports native flag settings (see my discourse help).
I have just 2 months of ample time recently, and I am very happy to set up an interface for fftpack to make a long-term development attempt.
My current done job (added fpm support for two version of fftpack):
I simply migrated netlib/dfftpack1.0 (fftpack4.0) to the branch fortran-fans/fftpack4.0 (License: public domain), and initially added fpm support; At the same time, I simply migrated john/fftpack5.1(F90) to the branch fortran-fans/fftpack5.1 (License: GPL), and initially added fpm support. Obviously, it currently depends on -fallow-argument-mismatch.
My request (make two PRs):
I want to submit the above two versions of the fftpack package to your repo at the same time. My suggestion is to create a separate branch for fftpack4.0 and merge fftpack5.1 into your master branch (or a new branch named fftpack5.1). What do you think?
If you agree, you need to create a fftpack4.0 branch for me in your this repo, then I will make two PRs, thank you~
Potential problem (LICENSE):
Now I have not specified any license for these two packages, I am not familiar with it myself, and all licenses are kept as they are.
You recommended me (see fortran-lang/fpm-registry#40 (comment)) to check whether the code in this repository(
certik/fftpack
) is consistent withnetlib/dfftpack1.0 (fftpack4.0)
. I confirm that they are consistent.And I want to learn from brocolis/fftpack to make
dfftpack1.0(fftpack4.0)
also support fpm. I will do this immediately.Later, We update
dfftpack1.0(fftpack4.0)
tofftpack5.1
:netlib/dfftpack1.0(fftpack4.0) with a easy-to-use interface
(->ncar/fftpack5.1 with a easy-to-use interface
->john/fftpack5.1 with a easy-to-use interface
) ->fftpack5.1 with a easy-to-use interface
.I got inspiration from
stdlib
, I think we can usefypp
as a preprocessor to deal with the multi-precision problem offftpack
package.Do we need to use
fypp
to refactornetlib/dffpack1.0(fftpack4.0)
andnacr/fftpack5.1
?Tasks
fpm
support, keepmake
support)Such as
fftshift
,czt
,hilbert
,filter
.SAVE
feature to savewsave(:)
Links
Fortran77
Fortran77
Fortran90 from nacr/fftpack5.1
From John Burkardt fortran90, fftpack5.1 with interface.
From John Burkardt fortran90, fftpack5.1 with interface.
Fortran90, look like from nacr/fftpack5.1 ?
The text was updated successfully, but these errors were encountered: