Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAMR: rephrased error message to account for non-relayed users #1857

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

exploide
Copy link
Contributor

@exploide exploide commented Dec 2, 2024

When trying to add a new machine account without the proper right, an error message is returned explaining that the relayed user doesn't have the right.

However, it's not necessarily a user being relayed. It could also be a direct authentication attempt by addcomputer.py.

Therefore, I rephrased the error message to be less confusing and more generic.

@anadrianmanrique anadrianmanrique self-assigned this Dec 5, 2024
@anadrianmanrique anadrianmanrique added the medium Medium priority item label Dec 5, 2024
@anadrianmanrique anadrianmanrique merged commit 1e4de31 into fortra:master Dec 5, 2024
8 checks passed
@anadrianmanrique
Copy link
Contributor

Thanks!

@exploide exploide deleted the samr-error-strings branch December 5, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Medium priority item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants