-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dsinternals dependency #1704
Remove dsinternals dependency #1704
Conversation
…adrianmanrique/impacket into remove_dsinternals_dependency
Hey! From a functional point of view working fine with changes implemented (working like the current Only one detail, related to the new added helper file
They are automatically loaded at impacket/impacket/examples/ntlmrelayx/attacks/__init__.py Lines 46 to 77 in 985690e
Perhaps moving that class to another folder (ie: impacket/examples/ntlmrelayx/utils)? I'm still checking the code, later today will update 🚀 |
This PR removes dependency with dsinternals library, used in the context of shadow credentials in ntlmrelayx.
fixes #1637