Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redifination of hexdump() function in two files #1682

Merged
merged 1 commit into from
Feb 27, 2024
Merged

remove redifination of hexdump() function in two files #1682

merged 1 commit into from
Feb 27, 2024

Conversation

NtAlexio2
Copy link
Contributor

@NtAlexio2 NtAlexio2 commented Jan 12, 2024 •
edited
Loading

hexdump() and pretty_print(x) functions are defined multiple times in ntfs-read.py and ese.py files. This PR removes unnecessary redefinition and import function from one single source in structure.py.

@anadrianmanrique anadrianmanrique self-assigned this Feb 22, 2024
@anadrianmanrique anadrianmanrique added the medium Medium priority item label Feb 22, 2024
@anadrianmanrique anadrianmanrique merged commit 985690e into fortra:master Feb 27, 2024
9 checks passed
@anadrianmanrique
Copy link
Contributor

Thanks!

@NtAlexio2 NtAlexio2 deleted the optimization branch March 21, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@anadrianmanrique anadrianmanrique

Labels
medium Medium priority item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NtAlexio2 @anadrianmanrique