Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched to modern tools #4

Merged
merged 8 commits into from
Jul 19, 2024
Merged

Switched to modern tools #4

merged 8 commits into from
Jul 19, 2024

Conversation

AlemTuzlak
Copy link
Contributor

Fixes #

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Type of change

Please mark relevant options with an x in the brackets.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Algorithm update - updates algorithm documentation/questions/answers etc.
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

  • Integration tests
  • Unit tests
  • Manual tests
  • No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

  • Check if the UI is working as expected and is satisfactory
  • Check if the code is well documented
  • Check if the behavior is what is expected
  • Check if the code is well tested
  • Check if the code is readable and well formatted
  • Additional checks (document below if any)

Screenshots (if appropriate):

Questions (if appropriate):

Copy link

pkg-pr-new bot commented Jul 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: fd2ac79

open-source-stack

npm i https://pkg.pr.new/forge42dev/open-source-stack@4


templates

Copy link

github-actions bot commented Jul 17, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 100% (🎯 80%) 2 / 2
🟢 Statements 100% (🎯 80%) 2 / 2
🟢 Functions 100% (🎯 80%) 1 / 1
🟢 Branches 100% (🎯 80%) 1 / 1
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/index.ts 100% 100% 100% 100%
Generated in workflow #8

@AlemTuzlak AlemTuzlak requested a review from thomasfr July 17, 2024 12:09
Copy link

@thomasfr thomasfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
Switch to pnpm too much?

@AlemTuzlak AlemTuzlak merged commit 182deff into main Jul 19, 2024
6 checks passed
@AlemTuzlak AlemTuzlak deleted the modernization branch July 19, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants