-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design With FontForge: Japanese Translation #239
Conversation
Hi @J1-takai, Thank you for your time and effort putting this together. I started looking at this and noted 2 things that need fixing.
There is also a third thing that I think you may want to fix, which is the "author/commit" email. There is two ways to do this, the easier way is to change your homepage settings and add an email. then when you create a Pull-Request and the many commits you made, github will use the email you set for you homepage for the Author/Committer emails instead of an obfuscated email that only tracks back to github and doesn't give you recognition anywhere else. You can always remove your homepage email address again, after doing the commits if you do not want to have your email shown on your homepage. If you would rather I take care of all these, let me know (just provide me with an name+email to put on the commits), but otherwise, it looks basically as we close this Pull-request, and you start a new pull request, using folder ja-JP, and inserting all the files you already created, but add the fixed bookpage_ja-JP to all the pages. ...and once again - Thank You - this is a very impressive PR. |
…e, homepage/bookpage descriptions and inter-files links in the md files.
Hi @JoesCat , Thank you very much for your detailed checks and kind comments. I've made some corrections as mentioned above:
As for the email setting, I tried to add the second email address for communications, but I somehow could not show it visible (public) at my repository. Can I start a new pull request now? rgds |
Yes - I noticed - thank you.
Yes, it is an expected behaviour that you cannot edit the email on committed PRs. There is a way around it, but it gets technical. The easier way is to start a new pull request.
...on second thought, let us avoid this, and you continue doing the same method you are doing now (It appears I'll have to do the more technical method instead). ...okay, there's a couple more files that are worth adding too, if you can. No need to rush or hurry, as I need to do some other things in the meantime.... |
Thank you @JoesCat for your new suggestions and sorry for all the troubles I've caused due to my whim to have a Japanese version. (I should have made a pdf version instead - much easier to handle!). Now I created four *_ja-JP.html files as suggested above - I hope I have done them correctly. As for the repository issue, I better not dare to try it by myself as I am almost certain that I mess up the situation further. I’d like to leave it to a specialist. Please let me know what I should do next (yes, no rush, and whenever you have time to spare for me). At this moment, I am working on the Tutorials in Japanese in the pdf format - I took the easy road this time!! |
Actually, you did the right thing here by supplying your translations. There will always be some technical problems to fix, but that is part of the process. The main task, which is making a translation is done. Give yourself a pat on the back for a job well done - it is not an easy thing to do, but you did it - good work - Thank you!
Excellent! these are tiny details eaily overlooked - thank you for doing these too.
Yes! this part is a bit more technical - and understandably as a non-programmer, it is an issue that we should not insist on, so we work around this. :-)
Some of my delay was trying to find a workaround for the tools mentioned on the README, like jekyll and grunt since my computer doesn't have those tools. I think I've found a workaround to that. I'm looking at the gitK email....seems I made an error thinking it was an obfuscated github email, and now realizing I made an error since it's not an obfuscated email....just unexpected for me to see "jt.x-l88.4989" as part of an email - my error. Re-opening your pull request so it could be merged. |
Hi @J1-takai, Then there is a directory called "honkit-en-US" Inside the new "honkit-ja-JP" are a few files of interest. Then there is file SUMMARY.md - you could use the honkit-fr-FR and honkit-zh-CN examples to help. Inside the subdirectory styles, there is nothing to edit. leave the ebook.css file as-is. |
Hi @JoesCat Thank you for your support and assistance. Just finished the ebook related files.
Please let me know if any other modifications are required. kind regards - J. Takai |
Sorry I must have clicked the wrong button. "Reopen" requested. |
Thank you @J1-takai for your efforts on this. This is a very large Pull Request! Will merge it in now. Thanks again! |
Understand and thank you for your great help. Much appreciated. J.Takai |
FYI - if you want another "large" project, you might want to start a repo with this textfile NamesList.txt. This would eventually apply towards libuninameslist. This is the current popularity for libuninameslist. If you need an example to compare with ListeNoms.txt. NOTE: It is a very large file, so go as far as you want, start with the characters that would make most sense to you first, like the Japanese char set, and the ASCII chars, then others if you choose to continue as far as you want. Charset 0000...FFFF are about the most stable, while new chars (and emojis) are put in 10000...1fffff ...thanks again for you work on this PR. |
Outlook for Androidを取得差出人: Joe ***@***.***>送信日時: 木曜日, 6月 13, 2024 10:07:38 午前宛先: fontforge/designwithfontforge.com ***@***.***>CC: Junichi TAKAI (たかい じゅんいち) ***@***.***>; Mention ***@***.***>件名: Re: [fontforge/designwithfontforge.com] Design With FontForge: Japanese Translation (PR #239)
Thank you @J1-takai for your efforts on this.
This is a very large Pull Request! Will merge it in now.
Also will try to tackly some other PRs and issues, but hopefully sometime within next two weeks or so, we'll all see the results of your work.
Thanks again!
Joe
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hi @JoesCat Thanks to your suport, Japanese version of "Design With FontForge" is nicely merged to the website. However, I noticed that I made a mistake in the Index.md file where I forget to set Locale info to "ja-JP" (due to this, if a user clicks "JP edition", it still jumps to "US Index Page". The file was modified and uploaded. Please update the file. Sorry for bothering you so many times. J. Takai |
Mentioned here: #239 (comment) Correction as per: J1-takai@d411242
Hi @J1-takai - it took a little bit of searching to figure-out what was fixed, but I see it now index fix. I also note that it causes a few files in directory ebook to get deleted too, which is a bit too early for this yet. I more-or-less posted a commit in your name that does similar effect (but without deleting the ebook files). Once again, I hope to have a little help from you. Looking at your repository, and due to using the main tree-trunk branch instead of a new-branch, your repository will be out of alignment with the current updates. I think, the easiest way to resolve this (from your point of view) would be to delete your existing repo, and then import a fresh clone of designwithfontforge to bring you up to date. This way, your repo is once again, in-sync with the main designwithfontforge repo, and you will be able to create a fresh pull-request.
Another question.... |
Hi @J1-takai - I noticed a few days ago that you tried to create a "Design with Fontforge" repository. I created a mini-help-instructions so that it may help you. I've seen this problem many times over-n-over again with FontForge, as well as "Design with FontForge" as well as other repositories. I hope this helps: #253 If you find that it does help, that's great, as it will help others as well. |
Hi @JoesCat - thank you for your "clairvoyance" and timely advice. Actually I tried a couple of times to "clone" the repository, but the first one was cloned in my PC (via vs code) and tried the second one to clone repo into my personal Github area (but its setting did not look light). With your Help Guide, now it seems that I could get back to the right track halfway (I still have to setup the VS code to connect this newly cloned branch/folk. (Your Help guide was so useful that I should prom this in Japan). Sorry I have checked the previous issues (newly added info in the English version). I will check them once i am fully on track. The second point on jagged/pixely font edges - yes, I would like to have smooth scalable fonts for JP version too, but I have no knowledge on *.woff fonts... Please advice what I need to do for this issue. J, Takai |
Glad it helped :-)
I didn't get too far, next page to go is "Drawing with Spiro", and onwards.
It appears it has already been resolved. I ran a live distro of Ubuntu 24.04 to test-out some jekyll and it seems the fonts look a lot nicer there. Japanese and also noticed Chinese too. I'll need to change "Design with Fontforge" to use that font instead. |
Just completed the Japanese translation of DESIGN WITH FONTFORGE document. This is my first attempt of GitHub work as well as a document translation. Hope it works OK.