Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(calendar): remove data values on destroy #3033

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Apr 16, 2024

Description

data saved to the jquery calendar object was not removed on destroy. This leads to situations when a re-instantiation of the same calendar gets confused about different setting than the previous (data()-stored) values.

Testcase

  • Open the calendar, it should show the 6th of April in the header

Broken

Closes

#3031

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug state/awaiting-reviews Pull requests which are waiting for reviews javascript Pull requests that update Javascript code labels Apr 16, 2024
@lubber-de lubber-de added this to the 2.9.4 milestone Apr 16, 2024
@lubber-de lubber-de merged commit 28e0212 into fomantic:develop Apr 23, 2024
10 checks passed
@lubber-de lubber-de deleted the removeDataOnDestroy branch April 23, 2024 18:58
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant