Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible nil volumes for libvirt #133

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Fix possible nil volumes for libvirt #133

merged 1 commit into from
Oct 20, 2023

Conversation

ofedoren
Copy link
Contributor

@ekohl, whist I was trying to run Foreman tests on Ruby 2.7/3.0 via GA I've noticed that sometimes volumes can be [nil]. It's probably an issue with the setup, but the fix still makes this safer.

ekohl
ekohl approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruby 2.7+ has .filter_map for .map.compact but this gem is currently aiming for 2.5+ so this is correct.

@ekohl ekohl merged commit 16a7083 into fog:master Oct 20, 2023
6 checks passed
@ofedoren ofedoren mentioned this pull request Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofedoren @ekohl