Upgrade automation to Python 3.11 #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
approved these changes
Dec 20, 2024
Signed-off-by: Kingdon B <[email protected]> do not specify python version here it is specified in python/setup step for the GHA workflow Signed-off-by: Kingdon B <[email protected]> testing locally (revert to python 3.10) Signed-off-by: Kingdon B <[email protected]> tested locally and this worked Signed-off-by: Kingdon B <[email protected]> put this back to match exactly the upstream Signed-off-by: Kingdon B <[email protected]> pending changes to the rolodex / emeriti Signed-off-by: Kingdon B <[email protected]>
Signed-off-by: Kingdon B <[email protected]>
kingdonb
force-pushed
the
upgrade-python-3.11
branch
from
ec322eb to
662499b
Compare
|
This issue is almost certainly related to whatever works in my fork but does not work in the fluxcd/community repo: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why we have BOT_GITHUB_TOKEN here, we could replace it with
GITHUB_TOKENwhich is automatically included and request the permission through the workflow?I did actually test this end-to-end before I submitted:
and so I really did expect that to work!
Squashed and rebased my iteration from the other repo here, in case there was something important I did not include.
There is also an upgrade to Python 3.11 here, and #427 (which I will again rebase out of this one, so it can be merged separately)