-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send SMS directly (#57) #60
Conversation
please merge this 😆 |
lib/src/flutter_sms_platform.dart
Outdated
Future<String> sendSMS({ | ||
required String message, | ||
required List<String> recipients, | ||
required bool sendDirect, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be optional and default to false so it's not a breaking change.
@rodydavis sorry not sure who to ping on this but you were the last one to merge a PR in this repo if you could PTAL 🙏 |
@rodydavis Commenting to say this would be amazing to have, and you seem like the one to talk to to get things merged around here. Any chance we can get this feature soon? |
Reviewing now |
Does sending directly on android require the permission in the manifest? In other words can it be opted out of? I have had apps rejected because I used the API and wasn't considered a phone messaging app |
@rodydavis yes it does require that permission - we've had apps rejected ourselves for the same reason - the category for apps that are allowed to do this is very narrow. I've made the default for this argument The feature is more "opt-in" than needing to "opt-out" as if you do not add that manifest property and never call with |
Ok that is wonderful to hear! I will merge this and publish soon! I just wanted to make sure we don't have a lot of apps rejected over a version bump. |
Published! https://pub.dev/packages/flutter_sms |
Addresses issue #57 to allow the user to send an SMS message directly