Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle Command Test to Only Accept Gradle Declarative Apply #8325

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jesswrd
Copy link
Contributor

@jesswrd jesswrd commented Dec 18, 2024

Currently the tests accept both the old gradle imperative apply and the gradle declarative apply. Since all plugins have been migrated to the gradle declarative apply, we want all exmple app plugins to reflect that and only accept gradle declarative apply.

Fixes flutter/flutter#152656
Fixes flutter/flutter#157660

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jesswrd jesswrd added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Dec 18, 2024
@jesswrd jesswrd force-pushed the i1152656-update-repo-tooling-tests branch from b1fd75a to 2825aa0 Compare December 18, 2024 21:47
@jesswrd jesswrd force-pushed the i1152656-update-repo-tooling-tests branch from 2825aa0 to 46428e6 Compare December 18, 2024 22:57
@jesswrd jesswrd requested a review from reidbaker December 19, 2024 20:28
@jesswrd
Copy link
Contributor Author

jesswrd commented Dec 19, 2024

@reidbaker Requested review with a failing test, but it looks unrelated to my changes. It's from tip of tree.

@jesswrd jesswrd changed the title [WIP] Update Gradle Command Test to Only Accept Gradle Declarative Apply Update Gradle Command Test to Only Accept Gradle Declarative Apply Dec 19, 2024
@jesswrd jesswrd marked this pull request as ready for review December 19, 2024 21:40
@jesswrd jesswrd force-pushed the i1152656-update-repo-tooling-tests branch from 665422d to e30495e Compare December 21, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes
Projects
None yet
2 participants