-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pigeon] [swift] Changes PigeonError
class to conform to Sendable
.
#8302
base: main
Are you sure you want to change the base?
Conversation
This will break old sdk where Sendable is undefined. You may have to put it behind a flag. |
Are there any minimum Xcode requirements for Flutter projects? Sendable was added in Xcode 13.0 with Swift 5.5. |
packages/pigeon/CHANGELOG.md
Outdated
@@ -1,6 +1,7 @@ | |||
## NEXT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be updated to 22.7.1 along with the pubspec version and the generator_tools file.
I guess this is technically a breaking change, so 23.0.0 might be more correct.
packages/pigeon/CHANGELOG.md
Outdated
@@ -1,6 +1,7 @@ | |||
## NEXT | |||
|
|||
* Updates minimum supported SDK version to Flutter 3.22/Dart 3.4. | |||
* [swift] Make `PigeonError` Class Conform to `Sendable` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[swift] Changes `PigeonError` class to conform to `Sendable`.
@stuartmorgan shouldn't this pr be failing the test exemption check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after addressing the comments.
PigeonError
Class Conform to Sendable
PigeonError
class to conform to Sendable
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stuartmorgan shouldn't this pr be failing the test exemption check?
I think there's a false negative due to the changes to generated files in platform_tests
; we should probably tune the Cocoon rules to ignore .gen.
files in there.
Regardless, this does need testing. A Dart unit test should be fine for this for now (although long term we probably want to adjust the Swift integration tests to actually test a flow that ensures that everything is Sendable
)
Make
PigeonError
conform toSendable
for compatibility with Swift 6.0 mode by changing thedetails
property type fromAny?
toSendable?
.Fixes flutter/flutter#160313
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.