Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[video_player_avfoundation] fix video playback speed resetting on iOS 16+ #8274

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+73 −1
Open

[video_player_avfoundation] fix video playback speed resetting on iOS 16+ #8274

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fda3b04
fix video playback speed resetting on iOS 16+
sha3rawi33 Dec 8, 2024
7ef856b
Merge branch 'flutter:main' into main
sha3rawi33 Dec 11, 2024
6415bc4
add tests
sha3rawi33 Dec 11, 2024
646e33a
added objc test unit
sha3rawi33 Dec 11, 2024
6b8da1a
added comments
sha3rawi33 Dec 11, 2024
8cd0840
added test for defaultRate
sha3rawi33 Dec 11, 2024
d080607
Merge branch 'flutter:main' into main
sha3rawi33 Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,9 @@ - (void)setPlaybackSpeed:(double)speed {
}
return;
}

if (@available(iOS 16, *)) {
sha3rawi33 marked this conversation as resolved.
Show resolved Hide resolved
_player.defaultRate = speed;
}
_player.rate = speed;
}

Expand Down
Loading