-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[go _route] fragment parameter added #8232
Open
AffanShaikhsurab
wants to merge
19
commits into
flutter:main
Choose a base branch
from
AffanShaikhsurab:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+97
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashes to URLs, whichcould lead to potential bugs. This update introduces a dedicated fragment parameter, allowing for more seamless and reliable URL navigation.
AffanShaikhsurab
changed the title
Previously, users had to manually append fragments
[go _route] fragment parameter added
Dec 5, 2024
to remove the Linux repo_checks error.
@chunhtai @hannah-hyj Can you please tell me what improvements I should make? |
chunhtai
reviewed
Dec 9, 2024
namedLocation api final location = context.namedLocation( 'details', fragment: 'section3', ); context.go(location);
chunhtai
reviewed
Dec 12, 2024
This fix ensures that the fragment is properly included when generating the URI using namedLocation in router.dart.
chunhtai
reviewed
Dec 17, 2024
- Added logic to redirect to '/route/1' if the fragment is '1' in the '/route' route. - Updated test to verify correct redirection and ensure no infinite redirects occur. - Ensured proper navigation based on fragment values using router.goNamed(). - Added assertions to check for expected behavior and prevent exceptions during navigation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR addresses the need for fragments/hashes to be treated as first-party parameters within the
go_router
package, as highlighted in issue #150155. Previously, users had to manually append the fragment to the URL, which could lead to potential bugs. With this update, thefragment
is now a dedicated parameter, allowing for a more seamless and bug-free integration.Before:
After:
Issues Fixed
This PR resolves issue #150155.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.