[vector_graphics] Allow transition between placeholder and loaded image to have an animation #8195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stuartmorgan Can you review this? |
|
@jonahwilliams Are these package's PRs being included in engine PR triage? |
|
They were not |
jonahwilliams
requested changes
Dec 16, 2024
| @@ -61,6 +61,7 @@ VectorGraphic createCompatVectorGraphic({ | |||
| String? semanticsLabel, | |||
| bool excludeFromSemantics = false, | |||
| Clip clipBehavior = Clip.hardEdge, | |||
| Duration transitionDuration = const Duration(milliseconds: 500), | |||
There was a problem hiding this comment.
This doesn't just allow the transition, it forces it on for all apps. should this be opt in if a transition duration is specififed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
Issue #158857
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].///).If you need help, consider asking for advice on the #hackers-new channel on [Discord].