Skip to content

Commit

Permalink
[tool] Build all_packages command against Flutter Android SDK version…
Browse files Browse the repository at this point in the history
… to match example apps
  • Loading branch information
jmagman committed Dec 24, 2024
1 parent ebe9b86 commit d36d4a9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions script/tool/lib/src/create_all_packages_app_command.dart
Original file line number Diff line number Diff line change
Expand Up @@ -243,9 +243,9 @@ dependencies {}
gradleFile,
replacements: <String, List<String>>{
if (gradleFileIsKotlin)
'compileSdk': <String>['compileSdk = 34']
'compileSdk': <String>['compileSdk = flutter.compileSdkVersion']
else ...<String, List<String>>{
'compileSdkVersion': <String>['compileSdk 34'],
'compileSdkVersion': <String>['compileSdk flutter.compileSdkVersion'],
}
},
regexReplacements: <RegExp, List<String>>{
Expand Down
4 changes: 2 additions & 2 deletions script/tool/test/create_all_packages_app_command_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ android {
buildGradle,
containsAll(<Matcher>[
contains('This is the legacy file'),
contains('compileSdk 34'),
contains('compileSdk flutter.compileSdkVersion'),
]));
});

Expand Down Expand Up @@ -375,7 +375,7 @@ android {
expect(
buildGradle,
containsAll(<Matcher>[
contains('compileSdk 34'),
contains('compileSdk flutter.compileSdkVersion'),
contains('androidx.lifecycle:lifecycle-runtime'),
]));
});
Expand Down

0 comments on commit d36d4a9

Please sign in to comment.