[web] Add 'flt-semantics-identifier' attribute to semantics nodes #53278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-mazhnik
reviewed
Jun 7, 2024
|
|
||
| void _updateIdentifier() { | ||
| if (semanticsObject.hasIdentifier) { | ||
| setAttribute('semantics-identifier', semanticsObject.identifier!); |
There was a problem hiding this comment.
I wonder if it would be better to prefix it with data-?
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/data-*
There was a problem hiding this comment.
data- sounds like a good idea, but only works if we move from the flt- convention to it. For this PR, let's continue with the flt- convention and file an issue to move to data- (we'll also have to evaluate the pros and cons of using data attributes).
yjbanov
approved these changes
Jun 20, 2024
|
|
||
| void _updateIdentifier() { | ||
| if (semanticsObject.hasIdentifier) { | ||
| setAttribute('semantics-identifier', semanticsObject.identifier!); |
There was a problem hiding this comment.
data- sounds like a good idea, but only works if we move from the flt- convention to it. For this PR, let's continue with the flt- convention and file an issue to move to data- (we'll also have to evaluate the pros and cons of using data attributes).
mdebbar
changed the title
mdebbar
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 21, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 21, 2024
…150637) flutter/engine@dda82d9...33415c6 2024-06-21 [email protected] Roll Dart SDK from 4483d67ba725 to fc1e5912fc94 (1 revision) (flutter/engine#53503) 2024-06-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix focus management for text fields (#51009)" (flutter/engine#53502) 2024-06-21 [email protected] Roll Dart SDK from 19d3e659f49a to 4483d67ba725 (2 revisions) (flutter/engine#53501) 2024-06-20 [email protected] [web] Add 'flt-semantics-identifier' attribute to semantics nodes (flutter/engine#53278) 2024-06-20 [email protected] [web] Don't add `href="#"` to semantics links (flutter/engine#53395) 2024-06-20 [email protected] Roll Dart SDK from be6b533e07e7 to 19d3e659f49a (1 revision) (flutter/engine#53495) 2024-06-20 [email protected] Roll Fuchsia Linux SDK from tD5pof7jVnbXPwP7l... to iU-B6rJxy0wUYSmmp... (flutter/engine#53493) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from tD5pof7jVnbX to iU-B6rJxy0wU If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
sigurdm
pushed a commit
to sigurdm/flutter
that referenced
this pull request
Jun 26, 2024
…lutter#150637) flutter/engine@dda82d9...33415c6 2024-06-21 [email protected] Roll Dart SDK from 4483d67ba725 to fc1e5912fc94 (1 revision) (flutter/engine#53503) 2024-06-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix focus management for text fields (flutter#51009)" (flutter/engine#53502) 2024-06-21 [email protected] Roll Dart SDK from 19d3e659f49a to 4483d67ba725 (2 revisions) (flutter/engine#53501) 2024-06-20 [email protected] [web] Add 'flt-semantics-identifier' attribute to semantics nodes (flutter/engine#53278) 2024-06-20 [email protected] [web] Don't add `href="#"` to semantics links (flutter/engine#53395) 2024-06-20 [email protected] Roll Dart SDK from be6b533e07e7 to 19d3e659f49a (1 revision) (flutter/engine#53495) 2024-06-20 [email protected] Roll Fuchsia Linux SDK from tD5pof7jVnbXPwP7l... to iU-B6rJxy0wUYSmmp... (flutter/engine#53493) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from tD5pof7jVnbX to iU-B6rJxy0wU If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 9, 2024
Updating the docs to reflect the change in flutter/engine#53278. `Semantics(identifier: '...')` can now be used on web to facilitate testing and DOM lookup when it comes to semantics nodes.
|
Hey @mdebbar The code I'm using is Semantics(
identifier: 'myid',
child: MyChild(),
),What I want to do, is to get the HTML element and prevent the default context menu on that element. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
Semantics(identifier: '...')useful on the web. This PR plugs the Semanticsidentifierproperty as an HTML attributeflt-semantics-identifieronto semantics elements.This is useful in some scenarios:
Fixes flutter/flutter#97455