Remove numpy from deps & some fixes #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will take a look tomorrow, thank you. Just want to clarify that this is mostly internal tool that is being used for our integration/e2e flipper tests at this moment. |
|
I mainly use it for reuploading an app after compilation. qFlipper-cli doesn't have file transfer cmds |
|
oh I see, that is one way to do it, I will talk to dev of qflipper, maybe it is easy to introduce to the cli version |
|
as for qflipper, there will be no updates sadly as for pull request, let me quickly go through code |
doomwastaken
requested changes
Nov 28, 2022
doomwastaken
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using numpy for a few functions seems quite excessive, I replaced it python lists. Also some bugfixes