Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FBT: Don't lint JS packages #4030

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Conversation

Willy-JL
Copy link
Contributor

@Willy-JL Willy-JL commented Dec 10, 2024

What's new

  • support for excluding folders in linter with ! prefix
  • exclude js packages dir as they have js naming convention (using dashes) so fbt would always complain

Verification

  • ./fbt format does not complain of applications/system/js_app/packages/fz-sdk and applications/system/js_app/packages/create-fz-app

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes
Copy link
Member

To be honest ! symbol is quite problematic in terms of how shell handles it.
It will work here, since args passed directly to subprocess without shell involvement.

@skotopes skotopes merged commit 33f1a16 into flipperdevices:dev Dec 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants