Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Fix ISO15693 stucking in wrong mode. #3988

Merged

Conversation

RebornedBrain
Copy link
Contributor

@RebornedBrain RebornedBrain commented Nov 5, 2024

What's new

  • Fix issue with parser stucking in wrong mode when working in noisy environment

This is an alternative fix for this issue #3343, which was mentioned in this pull request: #3885
Currently picopass should be able to restore correctly in case when 1_out_256 mode was choosen by mistake, due to noise during transmission.

Verification

  • Start picopass emulation on Flipper and put it into some noisy environment (I used generator which produced 13.56MHz modulated with 1_out_256 pattern, through with external antenna).
  • Try to read emulation with another Flipper using picopass app.
    Current result: At some point emulation stops responding and need to be restarted
    Fix result: Emulation restores by itself without restart.

Flipper which performs read can show errors during reading time to time because of injected noise.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@bettse
Copy link
Contributor

bettse commented Nov 17, 2024

How is the testing going on this?

@skotopes skotopes merged commit 9c96bbf into flipperdevices:dev Dec 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants