Update dependencies, generate update_metadata.rs based on protobuf 3.7 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dependencies running `cargo update`.
Main goal here is to update futures-util to 0.3.31, due to security warning
when running cargo-audit.
```
Crate: futures-util
Version: 0.3.28
Warning: yanked
Dependency tree:
futures-util 0.3.28
├── reqwest 0.11.26
│ └── ue-rs 0.1.0
├── hyper 0.14.28
│ ├── reqwest 0.11.26
│ └── hyper-tls 0.5.0
│ └── reqwest 0.11.26
└── h2 0.3.26
├── reqwest 0.11.26
└── hyper 0.14.28
error: 1 vulnerability found!
warning: 1 allowed warning found
```
Now that protobuf rust was updated to 3.7, generate update_metadata.rs again based on the new version, so that it includes correct _PROTOBUF_VERSION_CHECK, ::protobuf::VERSION_3_7_1.
So far README included wrong instructions for generating protobuf, using a prebuilt binary from protoc-bin-vendored crate. As the crate was stuck with older protobuf version 3.2, its output always had ::protobuf::VERSION_3_2_0. Update the instruction to include how to install a proper crate, protobuf-codegen, which allows us to generate protobuf with correct version ::protobuf::VERSION_3_7_1.
Fix warning when running cargo-clippy:
```
warning: the following explicit lifetimes could be elided: 'a
--> src/bin/download_sysext.rs:47:6
|
47 | impl<'a> Package<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
47 - impl<'a> Package<'a> {
47 + impl Package<'_> {
|
```
dongsupark
added a commit
to dongsupark/scripts
that referenced
this pull request
Nov 29, 2024
dongsupark
added a commit
to dongsupark/scripts
that referenced
this pull request
Nov 29, 2024
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Dec 2, 2024
Update ue-rs mainly to update dependency crates, as well as to address security warning around futures-util crate. Pulls in flatcar/ue-rs#58
1 task
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Dec 3, 2024
Update ue-rs mainly to update dependency crates, as well as to address security warning around futures-util crate. Pulls in flatcar/ue-rs#58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependencies running
cargo update. Main goal here is to updatefutures-utilto 0.3.31, due to security warning when runningcargo audit.Now that protobuf rust was updated to 3.7, generate
update_metadata.rsagain based on the new version, so that it includes correct_PROTOBUF_VERSION_CHECK,::protobuf::VERSION_3_7_1.So far README included wrong instructions for generating protobuf, using a prebuilt binary from protoc-bin-vendored crate. As the crate was stuck with older protobuf version 3.2, its output always had
::protobuf::VERSION_3_2_0. Update the instruction to include how to install a proper crate, protobuf-codegen, which allows us to generate protobuf with correct version::protobuf::VERSION_3_7_1.Fix clippy warning about
needless_timeout.