Add parameters to specify target filename #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Jan 16, 2024
This pulls in flatcar/ue-rs#49 and flatcar/update_engine#36 to fix the handling of OEM update payloads in a Nebraska response with self-hosted packages. Before this fix the processing failed and had to rely on the fallback download from the release server.
2 tasks
dongsupark
reviewed
Jan 17, 2024
When a match pattern has to be used, the resulting filename in the output directory is unknown. Add parameters to take only the first match and use a particular name for the extracted target file.
pothos
force-pushed
the
kai/target-filename
branch
from
591faf2 to
eaf8149
Compare
dongsupark
approved these changes
Jan 17, 2024
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Jan 18, 2024
This pulls in flatcar/ue-rs#49 and flatcar/update_engine#36 to fix the handling of OEM update payloads in a Nebraska response with self-hosted packages. Before this fix the processing failed and had to rely on the fallback download from the release server.
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Jan 18, 2024
This pulls in flatcar/ue-rs#49 and flatcar/update_engine#36 to fix the handling of OEM update payloads in a Nebraska response with self-hosted packages. Before this fix the processing failed and had to rely on the fallback download from the release server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a match pattern has to be used, the resulting filename in the output directory is unknown.
Add parameters to take only the first match and use a particular name for the extracted target file.
How to use
Should fix the problem with self-hosted update payloads.
Testing done
In scripts PR with Flatcar and also manual:
where the XML has entries like
<package name="extrafile-amd64-3815.0.0-oem-ami.gz" …