migrate error handling to anyhow #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsupark
force-pushed
the
dongsu/error-anyhow
branch
from
fafa809 to
4068ce3
Compare
Add a new dependency of `anyhow` crate, to use flexible concrete error handling mechanism, instead of the native error types.
dongsupark
force-pushed
the
dongsu/error-anyhow
branch
from
4068ce3 to
ae0ce7d
Compare
To follow error handling convention of anyhow, insert `.context` to add detailed message of error context when returning from functions. In case of an immediate error exit, use a `bail!` macro. Note, main functions and unit tests stay untouched if possible.
dongsupark
force-pushed
the
dongsu/error-anyhow
branch
from
ae0ce7d to
44d7530
Compare
pothos
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Some improvements would be good: Instead of writing errors to the terminal from functions that return Options it would be better to return Results.
Also, the dummy signature error is printed too prominently, we skip over it but it looks like the program crashed if you don't pay attention to the last line
Parsed and verified signature data from file "/var/tmp/outdir/.unverified/oem-ami.gz"
which indicates that it was successful.
|
Doing it in a follow-up is better, thus the approval. |
|
Thanks. I created a separate issue for the improvement of error handling. #28 |
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Dec 7, 2023
Update ue-rs to 0.1.0-r4, 2023-12-05. Pulls in flatcar/ue-rs#26, flatcar/ue-rs#29, flatcar/ue-rs#30, flatcar/ue-rs#36, flatcar/ue-rs#37, flatcar/ue-rs#39, flatcar/ue-rs#40.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new dependency of
anyhowcrate, to use flexible concrete error handling mechanism, instead of the native error types.To follow error handling convention of anyhow, insert
.contextto add detailed message of error context when returning from functions.In case of an immediate error exit, use a
bail!macro.Note, main functions and unit tests stay untouched if possible.
Fixes #25