Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When voiding an entry, add option to use date of original entry for the voiding entry, instead of the current date. #117 #118

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

tudorelu
Copy link
Contributor

@koresar
Copy link
Collaborator

koresar commented Nov 20, 2024

If used in production, the cached balances will be stale for some time. Dangerous. But I'm okay with that.
@Uzlopak ?

@koresar
Copy link
Collaborator

koresar commented Nov 20, 2024

Prettier need to be applied to the both files.

@hmvs
Copy link

hmvs commented Nov 20, 2024

If used in production, the cached balances will be stale for some time. Dangerous. But I'm okay with that.
@Uzlopak ?

It makes sense to point it out as a known issue for this use case in README.

@tudorelu
Copy link
Contributor Author

If used in production, the cached balances will be stale for some time. Dangerous. But I'm okay with that.

Re cached balances, I could also clear the balances table if use_original_date is set to true.

Or I could add it as a known issue in the README. Happy to do either.

@koresar
Copy link
Collaborator

koresar commented Nov 20, 2024

known issue is better IMO.

@tudorelu
Copy link
Contributor Author

Okay, all done 👍 let me know if anything else needs doing before we can merge.

@koresar koresar merged commit be2f46e into flash-oss:master Nov 28, 2024
@koresar
Copy link
Collaborator

koresar commented Nov 28, 2024

Published as [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants