feat: config query grammar #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmehrotra
force-pushed
the
config-queries
branch
2 times, most recently
from
597cc87 to
099b828
Compare
moshloop
commented
Dec 31, 2024
moshloop
commented
Dec 31, 2024
| var _ = Describe("grammer", func() { | ||
|
|
||
| It("parses", func() { | ||
| result, err := ParsePEG("john:doe metadata.name=bob metadata.name!=harry spec.status.reason!=\"failed reson\" -jane johnny type!=pod type!=replicaset namespace!=\"a,b,c\"") |
There was a problem hiding this comment.
Can we expand these tests out ?
moshloop
commented
Dec 31, 2024
| }{ | ||
| { | ||
| description: "config item query", | ||
| query: `name="node-b" type="Kubernetes::Node"`, |
There was a problem hiding this comment.
Suggested change
| query: `name="node-b" type="Kubernetes::Node"`, | |
| query: `name=node-b type=Kubernetes::Node`, |
There was a problem hiding this comment.
can we also add a name=node-b type=kubernetes::node (case insensitivity)
There was a problem hiding this comment.
Doing the suggested will cause the test to fail as things get parsed incorrectly
yashmehrotra
force-pushed
the
config-queries
branch
from
f4fa27f to
9c7f06f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.