Fix for Order-Dependent Flaky Test #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update test_iter.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed flaky test when run: pytest --flake-finder test_iter.py. This fix addresses an Order-Dependent Brittle (OD-Brit) flaky test caused by reusing an exhausted iterator in multiple function calls. The test failed due to the iterator being consumed after its first use, leading to a StopIteration error on subsequent calls.
The fix recreates fresh iterators before passing them to functions (first() and last()) to ensure the iterator isn't exhausted between uses, and conditional handling was added for non-iterable types (like lists and tuples) to allow direct reuse without exhaustion issues.
This ensures that the tests now run consistently without being affected by the state of the iterators.