Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDBetteridge/pip install #10

Closed
wants to merge 13 commits into from
Closed

Conversation

JDBetteridge
Copy link
Member

Make libsupermesh pip installable

@JDBetteridge JDBetteridge force-pushed the JDBetteridge/pip_install branch from d0483b5 to 710d17f Compare October 28, 2024 22:55
@JDBetteridge JDBetteridge force-pushed the JDBetteridge/pip_install branch from 710d17f to 4567eb7 Compare October 29, 2024 11:39
@connorjward
Copy link
Contributor

This is not yet ready for merge as it does not work on Macs. In particular it is not producing a viable .dylib that Firedrake can link to in setup.py. I think the solution is something to do with the CMake suffix (see here about sysconfig.get_config_var("SO")) but until I have access to a Mac to develop on this can't go anywhere.

Once this has been fixed the changes that were reverted here may be restored.

@connorjward connorjward marked this pull request as draft November 20, 2024 14:29
@connorjward
Copy link
Contributor

# libsupermesh
# example:
# gcc -I/supermesh/include
# gcc /supermesh/supermesh.cpython-311-x86_64-linux-gnu.so \
#    -l:supermesh.cpython-311-x86_64-linux-gnu.so \
#    -Wl,-rpath,$ORIGIN/../../supermesh
supermesh_dir = Path(supermesh.__path__._path[0]).absolute()
supermesh_so = next(supermesh_dir.glob('*.so'))
supermesh_ = ExternalDependency(
    libraries=[f":{supermesh_so.name!s}"],
    include_dirs=[str(supermesh_dir.joinpath("include"))],
    library_dirs=[str(supermesh_dir)],
    runtime_library_dirs=[os.path.join(site.getsitepackages()[0], "supermesh")]

since it got lost...

@connorjward
Copy link
Contributor

Superseded by #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants