u.sub(0) should still be in a ComponentFunctionSpace if the vector is 1 dimensional
#3902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…keproject/firedrake into JHopeCollins/vector_sub1
|
|
connorjward
requested changes
Dec 3, 2024
Co-authored-by: Connor Ward <[email protected]>
connorjward
approved these changes
Dec 3, 2024
pbrubeck
reviewed
Dec 4, 2024
| if self.dof_dset.cdim == 1: | ||
| return (self, ) | ||
| if self.function_space().rank == 0: | ||
| return tuple((self, )) |
pbrubeck
reviewed
Dec 4, 2024
| if self.function_space().block_size == 1: | ||
| return (self, ) | ||
| if self.function_space().rank == 0: | ||
| return tuple((self, )) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currrently, for
uin aVectorFunctionSpace, theFunctionsreturned byu.subare in different types of spaces depending on the dimension of the VFS.dimis 2 or higher, thenu.sub(i).function_space()is aComponentProxyFunctionSpace.dimis 1, thenu.sub(0) is u, instead of being in theComponentProxyFunctionSpace.This PR changes the
u.sub(0)for 1-dim vectors to be in theComponentProxyFunctionSpaceby changing the if-statement to testself.rankinstead ofself.dof_dset.cdim.Change made here:
firedrake/firedrake/function.py
Line 127 in a2a9448
The rest of the changes are making how/where the mixed/vector-ness is tested in subfunctions/sub/_components consistent across functions and function spaces.