Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single source of truth #120

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Single source of truth #120

merged 3 commits into from
Dec 20, 2024

Conversation

pbrubeck
Copy link

@pbrubeck pbrubeck commented Dec 14, 2024

With this PR, adding a new element to Firedrake would only require modifying the FIAT repo.

Firedrake PR: firedrakeproject/firedrake#3929

@pbrubeck pbrubeck force-pushed the pbrubeck/single-source branch from aacda66 to 519376b Compare December 14, 2024 23:34
@pbrubeck pbrubeck requested a review from connorjward December 18, 2024 12:32
Copy link

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are moving all this code from TSFC are there any tests that also need moving?

@pbrubeck pbrubeck force-pushed the pbrubeck/single-source branch from 19658bb to 565d5cb Compare December 19, 2024 16:59
@pbrubeck pbrubeck force-pushed the pbrubeck/single-source branch from 565d5cb to bcc3ebe Compare December 19, 2024 17:04
@pbrubeck pbrubeck merged commit 55114ef into master Dec 20, 2024
8 checks passed
@pbrubeck pbrubeck deleted the pbrubeck/single-source branch December 20, 2024 16:24
@pbrubeck pbrubeck mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants