Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detailed Container Registry Features #595

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Detailed Container Registry Features #595

wants to merge 4 commits into from

Conversation

smendis-scottlogic
Copy link
Contributor

detailed container registry features

@smendis-scottlogic smendis-scottlogic requested review from a team as code owners December 17, 2024 20:05
@eddie-knight
Copy link
Contributor

Hey @smendis-scottlogic— I'm not super confident with using CtrReg. If possible, I'd like to get a third opinion regarding whether we can provide clarity in the ID... this one seems like it's gonna be tough.

sshiells-scottlogic
sshiells-scottlogic reviewed Dec 18, 2024
View reviewed changes
services/devtools/container-registry/features.yaml Outdated Show resolved Hide resolved
services/devtools/container-registry/features.yaml
Ability to list all repositories in the container image registry.

- id: CCC.CtrReg.F11
title: Edit Repository
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add "Create Repository", "Create Image" and "Create Lifecycle Policy" or is that too far?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm bit confused myself with this. I have . I added the "Create Private Repository", "Create Public Repository", "Create Image" and "Create Lifecycle Policy" and then removed them thinking then there is no value in having "Private Repository", "Public Repository", "Image Storage", "Lifecycle Rules". Not sure whether to have them all, or creates or just functionality.

@smendis-scottlogic
Copy link
Contributor Author

Hey @smendis-scottlogic— I'm not super confident with using CtrReg. If possible, I'd like to get a third opinion regarding whether we can provide clarity in the ID... this one seems like it's gonna be tough.

What about ContainerReg (This has more than 8 chars we initially agreed upon) or ImageReg?

@sshiells-scottlogic
Copy link
Contributor

sshiells-scottlogic commented Dec 18, 2024 •
edited
Loading

CntrReg, ContReg, ContrReg?

@smendis-scottlogic
Copy link
Contributor Author

CntrReg also looks good to me. @eddie-knight any thoughts?

@damienjburks
Copy link
Contributor

@smendis-scottlogic CntrReg has my vote

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshiells-scottlogic sshiells-scottlogic sshiells-scottlogic left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smendis-scottlogic @eddie-knight @sshiells-scottlogic @damienjburks