Atualiza as propriedades do componente Tooltip para serem compatíveis com a nova versão (Tooltip v2)
#1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aprendendofelipe
force-pushed
the
primer/react
branch
from
dfe4141 to
6f1029e
Compare
Rafatcb
approved these changes
Aug 30, 2024
Rafatcb
added
front
eliasamaral
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoje utilizamos a v1 do Tooltip do Primer, que já está obsoleta e pode ser removida no futuro. Então esse PR já adequa as propriedades de maneira compatível com a v2 para cumprir com uma nova regra de lint do plugin
eslint-plugin-primer-react. Para o nosso caso, a v1 funciona perfeitamente com as mesmas propriedades da v2.Ainda não podemos simplesmente mudar para a v2, pois ela não é compatível com a maneira que usamos o Tooltip na barra de ocultar comentários (e talvez em outros locais... é preciso testar e adequar cada um).
Mudanças realizadas
textao invés dearia-label. No HTML gerado continua comoaria-label.noDelay, o que não gera mudança visual significativa.wrap, que não tinha efeito prático onde estava sendo usada.@primer/octicons-react,@primer/reacteeslint-plugin-primer-react, sendo esse último o responsável pelas adequações acima de forma automática.Checklist:
Obs.: Infelizmente permanecem os alertas antigos do Primer (primer/react#4836)