Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manual check for content on our Frisbii #94

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Sep 10, 2024

No description provided.

@bajtos bajtos requested a review from juliangruber September 10, 2024 12:44
@bajtos
Copy link
Member Author

bajtos commented Sep 10, 2024

Should we add an automated test for this?

Signed-off-by: Miroslav Bajtoš <[email protected]>
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for starting this PR 🙏

manual-check.js Show resolved Hide resolved
@bajtos bajtos requested a review from juliangruber September 12, 2024 13:33
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff!

@juliangruber
Copy link
Member

@juliangruber
Copy link
Member

However standard output doesn't make sense 🤔

@juliangruber
Copy link
Member

I assume we can fix this the dirty way by pinning standard to a specific version

@bajtos
Copy link
Member Author

bajtos commented Sep 12, 2024

standard/standard#1976

@bajtos
Copy link
Member Author

bajtos commented Sep 12, 2024

Let's disable standard linter for now, so that we can land this PR:

@bajtos
Copy link
Member Author

bajtos commented Sep 13, 2024

All is good now; standard fixed the problem.

@bajtos bajtos merged commit 0082af5 into main Sep 13, 2024
2 checks passed
@bajtos bajtos deleted the manual-check-frisbii branch September 13, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ done
Development

Successfully merging this pull request may close these issues.

2 participants