Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log error activity when no stationId #61

Closed
wants to merge 2 commits into from

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Apr 18, 2024

Example output:

❯ zinnia run main.js
[11:14:28.293 ERROR] Your Station version is outdated. Please upgrade it as soon as possible.
Getting current SPARK round details...
[11:14:28.399  INFO] SPARK started reporting retrievals

I am not convinced this is needed or a good idea, let me know what do you think.

/cc @juliangruber @PatrickNercessian

Links:

@bajtos bajtos requested a review from juliangruber April 18, 2024 09:16
Signed-off-by: Miroslav Bajtoš <[email protected]>
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have the API reject these, so that it leads to a more noticeable error.

@bajtos
Copy link
Member Author

bajtos commented Apr 18, 2024

I'd rather have the API reject these, so that it leads to a more noticeable error.

I am fine with that too.

IIRC, when the API rejects measurements, Spark will turn to the offline state. It's more noticeable but also does not explain to the user how to fix the problem.

Maybe we can implement both measures?

@juliangruber
Copy link
Member

With Station Desktop, we have auto updates, so I don't think we need to focus on outdated nodes there. And with Station Core, it's very visible in the logs. We could improve it, but I think for Core it's not that relevant

@juliangruber
Copy link
Member

I would instead suggest to add Watchtower documentation, so that Core nodes on Docker also have auto updates?

@bajtos
Copy link
Member Author

bajtos commented Apr 22, 2024

I don't fully agree, but I also don't want us to spend too much time discussing this topic.

I am fine to focus our efforts on improving the auto-updater for both Desktop and Core.

I am closing this pull request as rejected.

I would instead suggest to add Watchtower documentation, so that Core nodes on Docker also have auto updates?

Created a new issue here: filecoin-station/core#420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ done
Development

Successfully merging this pull request may close these issues.

2 participants