Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change success definition #33

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Change success definition #33

merged 3 commits into from
Oct 9, 2023

Conversation

juliangruber
Copy link
Member

@juliangruber juliangruber commented Oct 4, 2023 •
edited
Loading

Ref #28 (comment)

@bajtos I've removed .success, since the presence of .carChecksum marks a successful retrieval

@juliangruber juliangruber changed the base branch from main to feat-checksum October 4, 2023 11:06
@juliangruber juliangruber marked this pull request as ready for review October 4, 2023 11:07
@juliangruber juliangruber mentioned this pull request Oct 4, 2023
Merged
bajtos
bajtos approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👌🏻

Can you please open a PR to remove success column from the measurements table?

@bajtos
Copy link
Member

bajtos commented Oct 4, 2023

Can you please open a PR to remove success column from the measurements table?

Forgot to mention where: https://github.com/filecoin-station/spark-api

@bajtos
Copy link
Member

bajtos commented Oct 4, 2023

That spark-api change should fix the test failure we are observing:

integration => file:///home/runner/work/spark/spark/test/integration.js:5:1
error: Error: Failed to submit measurement (400): Invalid .success - should be a boolean
  const err = new Error(`${errorMsg ?? 'Fetch failed'} (${res.status}): ${body}`)

@juliangruber juliangruber mentioned this pull request Oct 4, 2023
Merged
@juliangruber
Copy link
Member Author

Awesome 👌🏻

Can you please open a PR to remove success column from the measurements table?

filecoin-station/spark-api#100

@bajtos bajtos merged commit 1445c4b into feat-checksum Oct 9, 2023
1 check passed
@bajtos bajtos deleted the refactor/success branch October 9, 2023 14:18
bajtos added a commit that referenced this pull request Oct 10, 2023
@bajtos @juliangruber
feat: limit max download size + calculate SHA-256 checksum (#28)
b38ac0b 
* feat: limit download size to 200 MB per task

* feat: compute SHA-256 checksum of CAR payload

* Change success definition (#33)

- success -> healthy
- remove `success`
- update test

---------

Signed-off-by: Miroslav Bajtoš <[email protected]>
Co-authored-by: Julian Gruber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliangruber @bajtos