Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: persisted Station ID passed to Zinnia #424

Merged
merged 27 commits into from
Apr 25, 2024
Merged

feat: persisted Station ID passed to Zinnia #424

merged 27 commits into from
Apr 25, 2024

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Apr 23, 2024

Introduce the concept of a Station instance ID that's represented as a public key of an Ed25119 keypair.

Generate the keypair on the first start and store it in a state file. Load the keypair from the state file on subsequent starts.

Introduce an optional env var PASSPHRASE allowing operators to specific a passphrase that will be used to encrypt & decrypt the file storing the keypair.

Implement an upgrade path allowing users to start with an empty PASSPHRASE and later upgrade their deployment with a PASSPHRASE string. Station will load the plaintext keypair and encrypt it using the new PASSPHRASE when it detects this situation.

Forward the Station ID to Zinnia via env vars and include it in the telemetry data written to InfluxDB.

Closes #406

@bajtos bajtos requested a review from juliangruber April 23, 2024 14:25
Signed-off-by: Miroslav Bajtoš <[email protected]>
README.md Outdated Show resolved Hide resolved
Signed-off-by: Miroslav Bajtoš <[email protected]>
Copy link

socket-security bot commented Apr 23, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment Transitive: filesystem, shell +6 81.2 kB kentcdodds

View full report↗︎

Signed-off-by: Miroslav Bajtoš <[email protected]>
.github/workflows/ci.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
lib/paths.js Outdated Show resolved Hide resolved
lib/station-id.js Outdated Show resolved Hide resolved
@bajtos bajtos requested a review from juliangruber April 24, 2024 12:08
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
@bajtos
Copy link
Member Author

bajtos commented Apr 24, 2024

@juliangruber @PatrickNercessian I addressed the comments, and the pull request is ready for final review and merging.

@juliangruber if we manage to land this PR today, could you please land #414 as well, before publishing a new Station Core release.

@bajtos bajtos enabled auto-merge (squash) April 24, 2024 12:40
Signed-off-by: Miroslav Bajtoš <[email protected]>
README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants