Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been unable to reproduce #21 this using
SegmentedWaveguide
s of identical homogeneous ionospheres. This was possibly fixed with the modefinder parameters introduced inv0.2.0
(https://github.com/fgasdia/LongwaveModePropagator.jl/releases/tag/v0.2.0).However, I have found amongst segmented waveguides with many segments that sometimes there are bumps in amplitude and phase at the transitions. It is unclear whether this is a coding bug, physics, or implementation problem. It is also unclear whether this is strictly local to the transition or whether it is a problem that affects the fields further down the path.
Here are examples of a varying daytime scenario (also with varying ground and magnetic field) using 100 km segments.
First, a zoomed region of the amplitude plot for several different paths as modeled by LMP:
And here is a plot of the amplitude difference between LMP and LWPC: