Workplan for hooking up SUBDDs #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwallwork23
force-pushed
the
33_fix-subdd
branch
from
1636eb0 to
0a67bb6
Compare
jwallwork23
commented
Dec 11, 2024
Comment on lines
-1019
to
-1043
| #ifdef TRACERS_ON | ||
| select case (iorw) | ||
| case (ioread) | ||
| call tracerIO(fid, 'read_dist') | ||
| case (iowrite) | ||
| call tracerIO(fid, 'write_dist') | ||
| end select | ||
| #endif | ||
| #ifdef TRACERS_GC | ||
| select case (iorw) | ||
| case (ioread) | ||
| call IO_CHEM(fid, 'read_dist') | ||
| case (iowrite) | ||
| call IO_CHEM(fid, 'write_dist') | ||
| end select | ||
| #endif | ||
| #ifdef TRACERS_GC | ||
| #elif TRACERS_ON | ||
| select case (iorw) | ||
| case (ioread) | ||
| call IO_CHEM(fid, 'read_dist') | ||
| call tracerIO(fid, 'read_dist') | ||
| case (iowrite) | ||
| call IO_CHEM(fid, 'write_dist') | ||
| call tracerIO(fid, 'write_dist') | ||
| end select | ||
| #endif | ||
|
|
There was a problem hiding this comment.
This looked to me like a copy-paste error (the same code appears twice).
jwallwork23
commented
Dec 20, 2024
Comment on lines
+1914
to
+1950
| call inc_subdd(subdd,k,sddarr2d) | ||
| ! NOTE: OH index is obtained using Ind_ function (from State_Chm_Mod) with | ||
| ! key 'OH' on L1426 of GEOS-Chem/GeosCore/diagnostics_mod.F90. | ||
| case ('OH') | ||
| call inc_subdd(subdd,k,ptropo) ! TODO: Output correct field, not ptropo | ||
| ! NOTE: NO index is obtained using Ind_ function (from State_Chm_Mod) with | ||
| ! key 'NO' on L282 of GEOS-Chem/GeosCore/hco_interface_gc_mod.F90. | ||
| ! This index is used on L2653 to access an entry of | ||
| ! State_Chm%Species. | ||
| case ('NO') | ||
| call inc_subdd(subdd,k,ptropo) ! TODO: Output correct field, not ptropo | ||
| ! NOTE: O3 appears in State_Diag with index 1 | ||
| ! (see L18820 of GEOS-Chem/Headers/state_diag_mod.F90) | ||
| ! NOTE: O3 index is obtained using Ind_ function (from State_Chm_Mod) with | ||
| ! key 'O3' on L284 of GEOS-Chem/GeosCore/hco_interface_gc_mod.F90. | ||
| ! This index is used on L2601 to access an entry of | ||
| ! State_Chm%Species. | ||
| case ('O3') | ||
| call inc_subdd(subdd,k,ptropo) ! TODO: Output correct field, not ptropo | ||
| ! NOTE: NO2 index is obtained using Ind_ function (from State_Chm_Mod) | ||
| ! with key 'NO2' on L283 of GEOS-Chem/GeosCore/hco_interface_gc_mod.F90. | ||
| ! This index is used on L2627 to access an entry of | ||
| ! State_Chm%Species. | ||
| case ('NO2') | ||
| call inc_subdd(subdd,k,ptropo) ! TODO: Output correct field, not ptropo | ||
| ! NOTE: CO index is obtained using Ind_ function (from State_Chm_Mod) with | ||
| ! key 'CO' on L936 of GEOS-Chem/GeosCore/carbon_gases_mod.F90. | ||
| ! This index is used on L219 to access an entry of | ||
| ! State_Chm%Species. | ||
| case ('CO') | ||
| call inc_subdd(subdd,k,ptropo) ! TODO: Output correct field, not ptropo | ||
| ! NOTE: CH4 index is obtained using Ind_ function (from State_Chm_Mod) | ||
| ! with key 'CH4' on L540 of GEOS-Chem/GeosCore/global_ch4_mod.F90. | ||
| ! This index is used on L549 to access an entry of | ||
| ! State_Chm%SpcData. | ||
| case ('CH4') | ||
| call inc_subdd(subdd,k,ptropo) ! TODO: Output correct field, not ptropo |
There was a problem hiding this comment.
I guess these should be in an #ifdef TRACERS_GC block?
|
We discussed in today's meeting that this is done more neatly in Lee's implementation in |
Open
jwallwork23
added
invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33.
Includes changes from #63 so that will need to be merged first.