Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Correctly support readOnly query parameters in PATCH endpoint generation. #5481

Merged
merged 6 commits into from
Dec 26, 2024
Merged

fix(cli): Correctly support readOnly query parameters in PATCH endpoint generation. #5481

merged 6 commits into from
Dec 26, 2024

Conversation

eyw520
Copy link
Member

@eyw520 eyw520 commented Dec 26, 2024

Description

This fix correctly allows PATCH endpoints to omit readOnly query parameters.

Changes Made

  • Update if condition where PATCH endpoints were omitted from respecting readOnly params.

Testing

  • Unit tests added/updated
  • Manual testing completed

eyw520 and others added 2 commits December 26, 2024 11:18
@eyw520
fix(cli): correctly support readonly query parameters in patch endpoi…
bff6308 
…nt generation.
@eyw520
fix(cli): Improvements to example parsing error messages. (#5475)
ee777b1 
* Initial improvements to example parsing error messages.

* Concise errors.

* Updates

* US
@eyw520 eyw520 requested a review from dsinghvi as a code owner December 26, 2024 16:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 26, 2024 •
edited
Loading

🌿 Preview your docs: https://fern-preview-866474c7-4c4a-4054-924f-ec3cc77a3a85.docs.buildwithfern.com/learn

dsinghvi
dsinghvi approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@dsinghvi dsinghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fern/packages/cli/api-importers/openapi/openapi-ir-parser/src/openapi/v3/converters/ExampleEndpointFactory.ts

Line 59 in 85b22b4

skipReadonly: endpoint.method === "POST" || endpoint.method === "PUT",

Here's another place we check readonly (it may be worth consolidating these checks into a single shared helper function)

@eyw520 eyw520 merged commit 406561a into main Dec 26, 2024
53 checks passed
@eyw520 eyw520 deleted the eden/fix-patch-readonly branch December 26, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsinghvi dsinghvi dsinghvi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyw520 @dsinghvi