fix(typescript): Remove node-fetch in TypeScript SDK

docker/seed/Dockerfile.ts

@@ -4,15 +4,12 @@ RUN  yarn add \
   # jest
   [email protected] \
   @types/[email protected] \
-  # node fetch
-  [email protected] \
-  @types/[email protected] \
   # node
   @types/[email protected] \
   # qs
   [email protected] \
   @types/[email protected] \
-  # url join 
+  # url join
   [email protected] \
   @types/[email protected] \
   # readable stream

generators/typescript/sdk/CHANGELOG.md

@@ -5,6 +5,9 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.46.0] - 2024-12-27
+
+- Feat: Remove `node-fetch` from generated SDK dependencies and always use the global fetch function instead, this lets you bundle the SDK for the browser with tools like Vite and Rollup without marking node-fetch as external.
 ## [0.45.1] - 2024-12-27
 
 - Fix: Export everything inside of TypeScript namespaces that used to be ambient.

generators/typescript/sdk/VERSION

@@ -1 +1 @@
-0.45.1
+0.46.0

generators/typescript/sdk/features.yml

@@ -56,8 +56,7 @@ features:
   - id: RUNTIME_COMPATIBILITY
     advanced: true
     description: |
-      The SDK defaults to `node-fetch` but will use the global fetch client if present. The SDK works in the following
-      runtimes:
+      The SDK works in the following runtimes:
 
       - Node.js 18+
       - Vercel

generators/typescript/utils/commons/src/core-utilities/fetcher/FetcherImpl.ts

@@ -39,15 +39,11 @@ export class FetcherImpl extends CoreUtility implements Fetcher {
         addDependencies: (dependencyManager: DependencyManager): void => {
             dependencyManager.addDependency("form-data", "^4.0.0");
             dependencyManager.addDependency("formdata-node", "^6.0.3");
-            dependencyManager.addDependency("node-fetch", "^2.7.0");
             dependencyManager.addDependency("qs", "^6.13.1");
             dependencyManager.addDependency("readable-stream", "^4.5.2");
             dependencyManager.addDependency("@types/qs", "^6.9.17", {
                 type: DependencyType.DEV
             });
-            dependencyManager.addDependency("@types/node-fetch", "^2.6.12", {
-                type: DependencyType.DEV
-            });
             dependencyManager.addDependency("@types/readable-stream", "^4.0.18", {
                 type: DependencyType.DEV
             });

generators/typescript/utils/core-utilities/fetcher/src/fetcher/Fetcher.ts

@@ -1,6 +1,5 @@
 import { APIResponse } from "./APIResponse";
 import { createRequestUrl } from "./createRequestUrl";
-import { getFetchFn } from "./getFetchFn";
 import { getRequestBody } from "./getRequestBody";
 import { getResponseBody } from "./getResponseBody";
 import { makeRequest } from "./makeRequest";
@@ -64,17 +63,16 @@ export async function fetcherImpl<R = unknown>(args: Fetcher.Args): Promise<APIR
     }
 
     const url = createRequestUrl(args.url, args.queryParameters);
-    let requestBody: BodyInit | undefined = await getRequestBody({
+    const requestBody: BodyInit | undefined = await getRequestBody({
         body: args.body,
         type: args.requestType === "json" ? "json" : "other"
     });
-    const fetchFn = await getFetchFn();
 
     try {
         const response = await requestWithRetries(
             async () =>
                 makeRequest(
-                    fetchFn,
+                    fetch,
                     url,
                     args.method,
                     headers,
@@ -86,7 +84,7 @@ export async function fetcherImpl<R = unknown>(args: Fetcher.Args): Promise<APIR
                 ),
             args.maxRetries
         );
-        let responseBody = await getResponseBody(response, args.responseType);
+        const responseBody = await getResponseBody(response, args.responseType);
 
         if (response.status >= 200 && response.status < 400) {
             return {

generators/typescript/utils/core-utilities/fetcher/src/form-data-utils/FormDataWrapper.ts

@@ -19,7 +19,7 @@ export interface CrossPlatformFormData {
 
     appendFile(key: string, value: unknown, fileName?: string): Promise<void>;
 
-    getRequest(): MaybePromise<FormDataRequest<unknown>>;
+    getRequest(): MaybePromise<FormDataRequest<any>>;
 }
 
 export async function newFormData(): Promise<CrossPlatformFormData> {

generators/typescript/utils/core-utilities/fetcher/src/form-data-utils/__private__test__/multipart.upload.test.ts

@@ -4,7 +4,6 @@ import fs from "fs";
 import { Server } from "http";
 import multer from "multer";
 import { newFormData } from "../..";
-import { getFetchFn } from "../../fetcher/getFetchFn";
 import { RUNTIME } from "../../runtime";
 
 describe("Multipart Form Data Tests", () => {
@@ -48,7 +47,6 @@ describe("Multipart Form Data Tests", () => {
 
         await fdw.appendFile("file", new Blob([new Uint8Array(y)]), "asda");
 
-        const fetch = await getFetchFn();
         const response = await fetch("http://localhost:4567/upload", {
             method: "POST",
             ...(await fdw.getRequest()),
@@ -66,8 +64,6 @@ describe("Multipart Form Data Tests", () => {
             const y = fs.readFileSync("package.json");
             await fdw.appendFile("file", new File([y], "package.json"));
 
-            const fetch = await getFetchFn();
-
             const response = await fetch("http://localhost:4567/upload", {
                 method: "POST",
                 ...(await fdw.getRequest()),
@@ -85,8 +81,6 @@ describe("Multipart Form Data Tests", () => {
         const y = fs.createReadStream("package.json");
         await fdw.appendFile("file", y);
 
-        const fetch = await getFetchFn();
-
         const response = await fetch("http://localhost:4567/upload", {
             method: "POST",
             ...(await fdw.getRequest()),