feat(java): Implement global timeout configuration for generated clients. #5472
+2,027
−290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsinghvi
reviewed
Dec 23, 2024
generators/java/sdk/src/main/java/com/fern/java/client/generators/RootClientGenerator.java
Outdated
Show resolved
Hide resolved
|
Once you regenerate the seed snapshots, itll be easy to verify but this looks right to me! |
dsinghvi
reviewed
Dec 23, 2024
seed/java-sdk/alias/src/main/java/com/seed/alias/core/ClientOptions.java
Outdated
Show resolved
Hide resolved
dsinghvi
reviewed
Dec 23, 2024
seed/java-sdk/alias/src/main/java/com/seed/alias/core/ClientOptions.java
Show resolved
Hide resolved
dsinghvi
reviewed
Dec 23, 2024
dsinghvi
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support timeout configuration in Java client builder.
Changes Made
ClientOptionsGeneratorto support timeout method in generated ClientOptions.RootClientGeneratorto support timeout method during ClientOptions build.Testing