chore(java): Test java inline path parameters #5438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajgateno
commented
Dec 18, 2024
| return getMovie(movieId, request, null); | ||
| } | ||
|
|
||
| public Movie getMovie(String movieId, GetMovieRequest request, RequestOptions requestOptions) { |
There was a problem hiding this comment.
@amckinney Looks like this was already implemented. If we want, we can make this test more general and run it on other generators to see which ones we're missing to support this feature.
There was a problem hiding this comment.
In this case, we actually want movieId to be included in GetMovieRequest. That's what in-lined in the request is referring to.
There was a problem hiding this comment.
Gotcha, will get on this then!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test to verify that the Java SDK generator is handling inline path parameters correctly