Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sonarqube): add recipe #595

Merged
merged 5 commits into from
Oct 19, 2024
Merged

Conversation

YaMoef
Copy link
Contributor

@YaMoef YaMoef commented Oct 11, 2024

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Added new recipe: SonarQube

recipes/sonarqube/package.json Outdated Show resolved Hide resolved
recipes/sonarqube/index.js Outdated Show resolved Hide resolved
recipes/sonarqube/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@vraravam vraravam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested, but looks good to me

@vraravam vraravam force-pushed the feature/sonarqube-recipe branch from 67e398c to 1dcfcc2 Compare October 16, 2024 01:29
Copy link
Contributor

@vraravam vraravam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YaMoef - looks like the CI run is failing. Most likely due to formatting changes that show up as modified files. Please run the commands locally and fix them before this PR can be approved and merged.

@YaMoef
Copy link
Contributor Author

YaMoef commented Oct 19, 2024

@YaMoef - looks like the CI run is failing. Most likely due to formatting changes that show up as modified files. Please run the commands locally and fix them before this PR can be approved and merged.

I ran the formatting commands, but I get locally issues with a version bump, is that ok? Or do I need to bump the version?

@vraravam
Copy link
Contributor

I ran the formatting commands, but I get locally issues with a version bump, is that ok? Or do I need to bump the version?

you can run the git commit command by bypassing the precommit checks with the -n switch. with this you can bypass the check for version bump.

@YaMoef
Copy link
Contributor Author

YaMoef commented Oct 19, 2024

I ran the formatting commands, but I get locally issues with a version bump, is that ok? Or do I need to bump the version?

you can run the git commit command by bypassing the precommit checks with the -n switch. with this you can bypass the check for version bump.

Perfect, this is what I did when I committed. The PR is good to go on my end :)

@vraravam vraravam force-pushed the feature/sonarqube-recipe branch from e8aa5c2 to 269f172 Compare October 19, 2024 14:11
@vraravam
Copy link
Contributor

@YaMoef - it is always a good idea to rebase from the latest version of the parent branch (main in this case) so that all of us can be assured that your changes will pass the CI tests on top of the latest so that when merged, the build will remain green. I have rebased now, but in the future (at least if contributing to Ferdium's repos), please ensure that your PR is rebased.

Copy link
Contributor

@vraravam vraravam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vraravam vraravam merged commit 62ed534 into ferdium:main Oct 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants