-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide init_kwargs to every transform within another transform #1228
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1228 +/- ##
==========================================
- Coverage 87.39% 84.81% -2.59%
==========================================
Files 92 92
Lines 6023 6039 +16
==========================================
- Hits 5264 5122 -142
- Misses 759 917 +158 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @nicoloesch! Could you please just add an explanation of what get_base_args
does/why it exists in Transform.get_base_args
? Just so our future selves or other maintainers have some context about it. I'll approve and merge after that.
@fepegar I added a docstring description to the method. I hope it is detailed enough! |
Fixes #1223.
Description
Certain transforms utilise already implemented transforms during their
apply_transform
method. However, these transforms are instantiated without the original arguments passed to the outer transform. These mainly includecopy
but may also extend toinclude
,exclude
,p
etc.This commit appends the initial arguments to each new instantiation of a base transform to reflect the user preference.
Checklist
CONTRIBUTING
docs and have a developer setup (especially important arepre-commit
andpytest
)pytest
make html
inside thedocs/
folder