Skip to content

Commit

Permalink
Removed unchanged notebooks, pub keyword in density_iteration and add…
Browse files Browse the repository at this point in the history
…ed docs for methods in IdealGas trait.
  • Loading branch information
g-bauer committed Feb 26, 2024
1 parent 399866e commit 5ceb67a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion feos-core/src/density_iteration.rs
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ pub fn density_iteration<E: Residual>(
}
}

pub(crate) fn pressure_spinodal<E: Residual>(
fn pressure_spinodal<E: Residual>(
eos: &Arc<E>,
temperature: Temperature,
rho_init: Density,
Expand Down
8 changes: 4 additions & 4 deletions feos-core/src/equation_of_state/ideal_gas.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ use num_dual::DualNum;

/// Ideal gas Helmholtz energy contribution.
pub trait IdealGas: Components + Sync + Send {
/// Implementation of an ideal gas model in terms of the
/// logarithm of the cubic thermal de Broglie wavelength
/// in units ln(A³) for each component in the system.
fn ln_lambda3<D: DualNum<f64> + Copy>(&self, temperature: D) -> Array1<D>;

/// Short description (usually the name) of the model.
fn ideal_gas_model(&self) -> String;

/// Evaluate the ideal gas Helmholtz energy contribution for a given state.
///
/// In some cases it could be advantageous to overwrite this
/// implementation instead of implementing the de Broglie
/// wavelength.
fn ideal_gas_helmholtz_energy<D: DualNum<f64> + Copy>(&self, state: &StateHD<D>) -> D {
let ln_lambda3 = self.ln_lambda3(state.temperature);
((ln_lambda3
Expand Down

0 comments on commit 5ceb67a

Please sign in to comment.