fix timeout error occuring in test #49

rachael-oregan · 2017-03-07T20:39:13Z

Motivation

Running npm test throws the following error:

1)  test express app listen is called:
     Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.
      at Context.exports.test express app listen is called (test/unit/test_application.js:82:10)

Result

Remove the return to ensure that the done() callback is being called.

pb82 · 2017-03-07T20:47:22Z

test/unit/test_application.js

@@ -79,7 +79,7 @@ exports['test express app listen is called'] = function(done) {
  runApp();

  mock.verify();
-  return done();
+  done();


the return should not make a difference here as long as done is called.

It only passes for me when return is removed?

fix timeout error occuring in test

c4faff4

rachael-oregan requested review from pb82, thailekha and sedroche March 7, 2017 20:40

pb82 reviewed Mar 7, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix timeout error occuring in test #49

fix timeout error occuring in test #49

rachael-oregan commented Mar 7, 2017

pb82 Mar 7, 2017

rachael-oregan Mar 7, 2017

fix timeout error occuring in test #49

Are you sure you want to change the base?

fix timeout error occuring in test #49

Conversation

rachael-oregan commented Mar 7, 2017

Motivation

Result

pb82 Mar 7, 2017

Choose a reason for hiding this comment

rachael-oregan Mar 7, 2017

Choose a reason for hiding this comment