Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spaces in $DNF_INSTALL #78

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Allow spaces in $DNF_INSTALL #78

merged 1 commit into from
Nov 25, 2024

Conversation

frenzymadness
Copy link
Member

Resolves: #74

Tested with:

podman run --rm -it -v $PWD:/src -w /src -e DNF_INSTALL="libyaml-devel libgit2-devel 'pytest > 7'" -e TOXENV=py313 fedora-python-tox:dnf_spaces

with a custom local build of the container image and it works fine.

@frenzymadness
Copy link
Member Author

Added test.

@hroncok
Copy link
Member

hroncok commented Nov 24, 2024

Thanks!

.github/workflows/build-and-push.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-push.yml Outdated Show resolved Hide resolved
@frenzymadness
Copy link
Member Author

I did not expect the test to take 22 minutes on arch64 😮 I'm gonna use your suggestion.

Resolves: #74

Co-authored-by: Miro Hrončok <[email protected]>
@frenzymadness
Copy link
Member Author

New test removed, suggestion squashed.

@frenzymadness frenzymadness merged commit 6fa7bfa into master Nov 25, 2024
5 checks passed
@frenzymadness frenzymadness deleted the dnf_spaces branch November 25, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNF_INSTALL cannot handle spaces
2 participants