Rebase our PR #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdba7dc Prepare for -sys release 0.5.0 (Jonas Nick) Pull request description: Top commit has no ACKs. Tree-SHA512: 5e766be36d0a27e9419be7ab81d53cb1d8d49c4da3e61d146b7cd0d74b159ad41a36c293bf48cdf228ef4f23d0caa439b8866f1784cd8eb69211799acf96c7d8
… and latest rust-secp c61a982 Fix warnings (sanket1729) 46a2c48 Updates upstream to 725d895fc54cf82da1c2a9c69048656405da556d See also the changed patch: secp256k1.h.patch (sanket1729) b1a3048 Update rust upstream (sanket1729) 3db533c Remove custom hash derives to fix build errors (sanket1729) ed64568 Comment out Wasm build on CI (sanket1729) Pull request description: The upstream impl_array_newtype now implements a core::Hash. This caused a breaking changed here :( despite it being a minor release. ACKs for top commit: sanket1729: Pushed to c61a982. The diff between the previous ACK and this one is null. thomaseizinger: ACK c61a982 apoelstra: utACK c61a982 Tree-SHA512: b59a0bf6dc4a6627ef2a5495f7a880fad8ff0ff4683bc5347512bb87b5343ee387b400d80990c09f2ce63edfde6c2686ffd8638e1088c4f8583a13eeb5e91af5
98994ee ffi: fix signature of whitelist_sign (Andrew Poelstra) Pull request description: The signature of whitelist_sign in our FFI bindings did not match the signature in the C libarry. Noticed when running local tests on BlockstreamResearch#55. Apparently wasm-pack notices stuff like this now and errors out :) ACKs for top commit: jonasnick: utACK 98994ee Tree-SHA512: a12d5260e2361aa2db06dbecf59f50a15aad1f04b5659dd265cc1bec01197e2b0c5378b903a0b5f6d4a39eeaf45bb69177bc32ef8e6b5733c9e006fcdf7d3c67
Code only require adding `crate::` to reference root level Updates also CI script to run with rust version 1.41.1 instead of 1.29.0
also rand: 0.6 -> 0.8 Change to add_assign parameter that doesn't require a slice anymore but a Scalar
e3a63b3 Fix *Proof::from_str (Leonardo Comandini) Pull request description: Deserializing `RangeProof`s and `SurjectionProof`s from `str` fails with current master. Add a fix and tests. ACKs for top commit: RCasatta: ACK e3a63b3 sanket1729: ACK e3a63b3 Tree-SHA512: 52b50931e14273ccf0528b48a9234308a2959b87748ae39c9f3bcead6d30747168d1c26efe6c371ea2059cc0c29a2b60b4bf1e814e268477df86d4c104cdb98d
850e5de cargo fmt (Riccardo Casatta) 72052a3 Avoid deprecated add_assign in favor of add_tweak (Riccardo Casatta) 655a24d secp256k1: bump 0.22.1 -> 0.24.0 (Riccardo Casatta) 5c54e6e Upgrade to 2018 edition, MSRV 1.41.1 (Riccardo Casatta) Pull request description: supersede BlockstreamResearch#58 ACKs for top commit: apoelstra: ACK 850e5de sanket1729: ACK 850e5de Tree-SHA512: a3f590d46c5cb32efbcf132ef62d46504aa12c5930524ab26dccc4532784d607e6e74fda6ec0ab2f12028dcf0bf9e89d6456b529339d5f0e4af941b16530994c
32ed375 Update secp256k1-zkp-sys in Cargo.toml (Riccardo Casatta) ba2fecb Updates upstream to d22774e248c703a191049b78f8d04f37d6fcfa05 (Riccardo Casatta) 09102ff update patch so that is applicable (Riccardo Casatta) 10c024d update Readme with correct MSRV (Riccardo Casatta) 6c91269 bump version to 0.7 and update CHANGELOG (Riccardo Casatta) Pull request description: ACKs for top commit: jonasnick: ACK 32ed375 Tree-SHA512: d0411daeda445eb151e3472ed66311190bcf80c25b5bde3f78b6829338b90468b40386d59b9cd56c93a001957a1a1fbd709e7f72947aee9c7ee37454460add9c
Co-authored-by: sanket1729 <[email protected]>
squash! zkp: Add Musig2 module Remove agg_pk from KeyAggCache Co-authored-by: sanket1729 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kind of don't know the context and what to do with this, but I rebased it and will try it out in fedimint to get fedimint/fedimint#389 working.